imatiach-msft commented on a change in pull request #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator URL: https://github.com/apache/spark/pull/17084#discussion_r259210190
########## File path: mllib/src/main/scala/org/apache/spark/mllib/evaluation/BinaryClassificationMetrics.scala ########## @@ -26,7 +26,7 @@ import org.apache.spark.sql.DataFrame /** * Evaluator for binary classification. * - * @param scoreAndLabels an RDD of (score, label) pairs. + * @param scoreAndLabelsWithOptWeight an RDD of (score, label, weight) tuples. Review comment: yes, good point, will update doc ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
