beliefer commented on a change in pull request #23842: [SPARK-26927]Fix race
condition may cause dynamic allocation not working
URL: https://github.com/apache/spark/pull/23842#discussion_r259228712
##########
File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala
##########
@@ -566,6 +574,13 @@ private[spark] class ExecutorAllocationManager(
if (executorIds.contains(executorId)) {
executorIds.remove(executorId)
removeTimes.remove(executorId)
+ if (!removedExecutorIds.offer(executorId)) {
Review comment:
Yes,this bug will lead to executorIds contains some removed executor id and
newExecutorTotal is an incorrect number.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
