jashgala commented on issue #23748: [SPARK-23619][SQL] Added default column names for explode & posexplode in comments URL: https://github.com/apache/spark/pull/23748#issuecomment-466297131 @maropu I've added comments for Inline and Stack in the `generators.scala` file. I didn't see these in the functions.* files though. @HyukjinKwon Have added comments in Python and R functions files as well as per the review comments above. I see that there are a lot of functions (e.g. mathematical functions, etc.) in the `functions.*` files. Is there value in adding the column names in the comments for all of them or do should we make this change specifically for the functions that are specifically used to generate columns/rows (e.g. explode, etc.)?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
