beliefer commented on a change in pull request #23869: [SPARK-26967][CORE] Put
MetricsSystem instance names together for clearer management
URL: https://github.com/apache/spark/pull/23869#discussion_r259305000
##########
File path: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
##########
@@ -235,3 +235,32 @@ private[spark] object MetricsSystem {
new MetricsSystem(instance, conf, securityMgr)
}
}
+
+private[spark] object MetricsSystemInstances {
+ // The Spark standalone master process
+ val MASTER = "master"
Review comment:
Maybe you lost
`core/src/main/scala/org/apache/spark/deploy/master/MasterSource.scala`
MasterSource have the code:
`override val sourceName = "master"`
There could reference `MetricsSystemInstances.MASTER`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
