srowen commented on a change in pull request #23818: 
[SPARK-19591][ML][PYSPARK][FOLLOWUP] Add sample weights to decision trees
URL: https://github.com/apache/spark/pull/23818#discussion_r259387137
 
 

 ##########
 File path: python/pyspark/ml/regression.py
 ##########
 @@ -791,19 +792,34 @@ class DecisionTreeRegressor(JavaEstimator, 
HasFeaturesCol, HasLabelCol, HasPredi
     >>> model.transform(test1).head().variance
     0.0
 
+    >>> df3 = spark.createDataFrame([
 
 Review comment:
   I guess I mean should we maintain an example without weights too? that might 
be the more common case. They don't both have to print depth, numNodes, etc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to