felixcheung commented on a change in pull request #23846: [SPARK-26729][K8S]
Make image names under test configurable
URL: https://github.com/apache/spark/pull/23846#discussion_r259237435
##########
File path:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala
##########
@@ -72,7 +72,7 @@ private[spark] trait SecretsTestsSuite { k8sSuite:
KubernetesSuite =>
doBasicExecutorPodCheck(executorPod)
checkSecrets(executorPod)
},
- appArgs = Array("1000") // give it enough time for all execs to be
visible
+ appArgs = Array("10000") // give it enough time for all execs to be
visible
Review comment:
2000? a factor of 10 seems a but much. generally we try not to add too many
sleep or delay - here or L108, because we run these test a lot.
also, this should be better as its own PR since this PR should be about
image name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
