vanzin commented on a change in pull request #23156: [SPARK-24063][SS] Add
maximum epoch queue threshold for ContinuousExecution
URL: https://github.com/apache/spark/pull/23156#discussion_r259432664
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1413,6 +1413,14 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ val CONTINUOUS_STREAMING_EPOCH_BACKLOG_QUEUE_SIZE =
+ buildConf("spark.sql.streaming.continuous.epochBacklogQueueSize")
+ .internal()
+ .doc("The max number of entries to be stored in queue to wait for late
epochs. " +
+ "If this parameter is exceeded by the size of the queue, stream will
stop with an error.")
+ .intConf
+ .createWithDefault(10000)
Review comment:
That's an issue because you're assuming that 10k is the number that will
cause a problem - i.e. nobody before this change was able to properly run a
query if this queue exceeded 10k items.
Meaning, that if this is checked in, all queries that fell into that case
(more than 10k items but not running into issues) will now break.
This also goes together with the "why is the config internal" question. What
is the reasoning for forcing this 10k value onto people, and not providing a
clear way for them to override it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
