srowen commented on a change in pull request #23856: [SPARK-26953][CORE][TEST] 
Test TimSort for ArrayIndexOutOfBoundsException
URL: https://github.com/apache/spark/pull/23856#discussion_r259563561
 
 

 ##########
 File path: 
core/src/test/scala/org/apache/spark/util/collection/SorterSuite.scala
 ##########
 @@ -241,6 +360,13 @@ class IntArraySortDataFormat extends 
AbstractIntArraySortDataFormat[Int] {
   }
 }
 
+class ByteArraySortDataFormat extends AbstractByteArraySortDataFormat[Byte] {
 
 Review comment:
   I forget it I asked -- why do we need this abstract parent class? can these 
be collapsed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to