Github user ash211 commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-66905391
I took a quick look, and some of the style seemed a little off from the
rest of Spark. I'm guessing the first Jenkins run will flag a few style errors
so it could be worth taking a look at
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
Specifically there's typically no space between map and the ( in `.map(` and
typically there is a space between a variable and its type, as in `volumes:
String`
I saw no tests either, which is a minor flag. The interactions between
Spark and other systems can be particularly difficult to test so we may be able
to do without coverage on this part for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
