dhruve commented on a change in pull request #22015:
[SPARK-20286][SPARK-24786][Core][DynamicAllocation] Release executors on
unpersisting RDD
URL: https://github.com/apache/spark/pull/22015#discussion_r259599838
##########
File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala
##########
@@ -804,6 +824,14 @@ private[spark] class ExecutorAllocationManager(
}
}
+ override def onUnpersistRDD(unpersistRDD: SparkListenerUnpersistRDD): Unit
= {
Review comment:
onExecutorIdle is called out only when a task ends on a given executor. So
unless there is a task which is scheduled on an executor which had previously
cached data but currently doesn't, spark will hold on to that executor forever.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
