maropu commented on a change in pull request #23854: [SPARK-22000][SQL] Address
missing Upcast in JavaTypeInference.deserializerFor
URL: https://github.com/apache/spark/pull/23854#discussion_r259604052
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##########
@@ -139,7 +139,7 @@ object ScalaReflection extends ScalaReflection {
* This method help us "remember" the required data type by adding a
`UpCast`. Note that we
* only need to do this for leaf nodes.
*/
- private def upCastToExpectedType(expr: Expression, expected: DataType,
+ private[spark] def upCastToExpectedType(expr: Expression, expected: DataType,
Review comment:
How about moving this function into `object Upcast {}`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
