HyukjinKwon edited a comment on issue #23879: [SPARK-26979][SQL] Add missing column name support for SQL functions URL: https://github.com/apache/spark/pull/23879#issuecomment-466766672 These generics are only applied to `functions.py`. Can you then whitelist one by one? I at least see one more instance, `trim` by `_create_function`. Also, there are few exceptions like `from_json` that takes `schema` as `Column` but also `DataType`. Plus, we should make it consistent in `dataframe.py` as well. `Column` and string are completely different types. It's not iterable or something related with duck-typing. See `help(max)` in Python.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
