srowen commented on a change in pull request #23878: [SPARK-26978][CORE] Avoid
magic time constants
URL: https://github.com/apache/spark/pull/23878#discussion_r259625045
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/GroupStateImpl.scala
##########
@@ -178,7 +179,7 @@ private[sql] class GroupStateImpl[S] private(
throw new IllegalArgumentException(s"Provided duration ($duration) is
not positive")
}
- val millisPerMonth = CalendarInterval.MICROS_PER_DAY / 1000 * 31
+ val millisPerMonth =
TimeUnit.MICROSECONDS.toMillis(CalendarInterval.MICROS_PER_DAY) * 31
Review comment:
Oh right of course. Hm, let's not change the logic here, but are the
semantics of a 'month' interval even meaningful! That's why CalendarInterval
breaks it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
