srowen commented on issue #23882: [SPARK-26979][PySpark][WIP] Add missing column name support for some SQL functions URL: https://github.com/apache/spark/pull/23882#issuecomment-466786925 I'm not against breaking out all the functions, just might be a lot of work for you. Yes, we do need tests, ideally. And I suppose that's what doctest is good for, and that would require breaking these out. If you want to go all the way to break out with brief doctests, I think that's OK. Otherwise I'd leave it for now. I like the idea of solving it in one go by modifying `_create_function` as it would be more consistent. Yes you're right that also requires special-casing. I'm missing why `asc` and `desc` are special; they also operate on columns so can take strings too?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
