cloud-fan commented on a change in pull request #23740: [SPARK-26837][SQL]
Pruning nested fields from object serializers
URL: https://github.com/apache/spark/pull/23740#discussion_r259867052
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
##########
@@ -93,6 +95,72 @@ case class SerializeFromObject(
override def output: Seq[Attribute] = serializer.map(_.toAttribute)
}
+object SerializeFromObject {
+ /**
+ * Collects all struct types from given data type object, recursively.
Supports struct and array
+ * types for now.
+ * TODO(SPARK-26847): support map type.
+ */
+ def collectStructType(dt: DataType, structs: ArrayBuffer[StructType]):
ArrayBuffer[StructType] = {
Review comment:
shall we move these 2 methods to `ObjectSerializerPruning`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
