HeartSaVioR commented on a change in pull request #23764: [SPARK-26825][SS] Fix
temp checkpoint creation in cluster mode when default filesystem is not local.
URL: https://github.com/apache/spark/pull/23764#discussion_r259999597
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
##########
@@ -222,12 +222,14 @@ class StreamingQueryManager private[sql] (sparkSession:
SparkSession) extends Lo
}.getOrElse {
if (useTempCheckpointLocation) {
deleteCheckpointOnStop = true
- val tempDir = Utils.createTempDir(namePrefix =
s"temporary").getCanonicalPath
+ val tempDir = System.getProperty("java.io.tmpdir")
+ val cpTempDir = new Path("file://" + tempDir + "/temporary-"
+ + UUID.randomUUID.toString).toString
Review comment:
> I am not sure adding "file://" prefix to root parameter would cause the
canonical path to return the final path with the same prefix.
That actually sounds serious to me and even sounds one reason to avoid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
