dongjoon-hyun commented on a change in pull request #23867: [SPARK-26965][SQL]
Makes ElementAt nullability more precise
URL: https://github.com/apache/spark/pull/23867#discussion_r260052366
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala
##########
@@ -281,10 +290,29 @@ case class GetArrayItem(child: Expression, ordinal:
Expression)
}
/**
- * Common base class for [[GetMapValue]] and [[ElementAt]].
+ * Common trait for [[GetMapValue]] and [[ElementAt]].
*/
+trait GetMapValueUtil extends BinaryExpression with ImplicitCastInputTypes {
Review comment:
Thanks. Then, what about `GetArrayItemUtil`? Actually, the reason why I
asked is that this PR makes some non-trivial lineages like the followings.
- `def BinaryExpression.left` -> `private val GetArrayItemUtil.child` ->
`override def GetArrayItem.left`.
- `def BinaryExpression.left` -> `private val GetMapValueUtil.child` ->
`override def GetMapValue.left`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
