Github user harishreedharan commented on the pull request:

    https://github.com/apache/spark/pull/3704#issuecomment-67050710
  
    This looks good to me, though the approach does not make it obvious why 
this approach was chosen (of course you can figure out in this context, but 
imagine reading this code a year later). 
    
    I think the other two are slightly simpler approaches by ensuring unique 
names on file creation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to