gaborgsomogyi commented on a change in pull request #23791:
[SPARK-20597][SQL][SS][WIP] KafkaSourceProvider falls back on path as synonym
for topic
URL: https://github.com/apache/spark/pull/23791#discussion_r260273079
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
##########
@@ -160,76 +204,93 @@ class KafkaSinkSuite extends StreamTest with
SharedSQLContext with KafkaTest {
}
}
- test("streaming - write aggregation w/o topic field, with topic option") {
+ /**
Review comment:
Not sure this description needed. The code should reflect the intention and
add comment if it's tricky (I know it's from the legacy code).
Such comments can deviate from code (where is 'bar' for example) and can
cause confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
