Nimfadora commented on a change in pull request #23791: [SPARK-20597][SQL][SS][WIP] KafkaSourceProvider falls back on path as synonym for topic URL: https://github.com/apache/spark/pull/23791#discussion_r260283201
########## File path: docs/structured-streaming-kafka-integration.md ########## @@ -457,8 +463,17 @@ The following configurations are optional: <td>string</td> <td>none</td> <td>streaming and batch</td> + <td>Sets the topic that all rows will be written to in Kafka. This option overrides + ```path``` option and any topic column that may exist in the data.</td> +</tr> +<tr> + <td>path</td> + <td>string</td> + <td>none</td> + <td>streaming and batch</td> <td>Sets the topic that all rows will be written to in Kafka. This option overrides any - topic column that may exist in the data.</td> + topic column that may exist in the data and is overridden by ```topic``` option. Review comment: How about the use-case when you want to have 'topic' column in your data with different topic values in it (e.g. "win", "click","visit"), but want to write that data to a single topic, so you override topic setting by topic (or path) option? I agree with you: user should not bother about overriding path option by topic option, but in my opinion we should not include topic field to this check and leave user a possibility to override topic column by topic or path option, whatever he likes most. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
