Github user tgaloppo commented on the pull request:
https://github.com/apache/spark/pull/3022#issuecomment-67076315
No worries; it'll get there. I appreciate the comments and pointers.
> On Dec 15, 2014, at 4:52 PM, jkbradley <[email protected]> wrote:
>
> @tgaloppo Thanks for the updates! You did exactly what I had in mind for
MultivariateGaussian; thanks.
>
> My main comments now are still about style. I realize it's annoying to
match a new style, but it is enforced pretty strictly with Spark to keep the
codebase uniform. I'll add some comments about style in the body, but probably
won't catch everything, so please check through and try to match. The Spark
style guide has some examples, and it links to the much more extensive Scala
style guide.
>
> I'll wait for the predict() patch & additional tests.
>
> I'll try to run some scaling tests myself and will put some results up
here before long.
>
> Thanks!
>
> â
> Reply to this email directly or view it on GitHub.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
