SongYadong commented on a change in pull request #23869: [SPARK-26967][CORE]
Put MetricsSystem instance names together for clearer management
URL: https://github.com/apache/spark/pull/23869#discussion_r260578068
##########
File path:
core/src/test/scala/org/apache/spark/metrics/MetricsSystemSuite.scala
##########
@@ -40,7 +40,8 @@ class MetricsSystemSuite extends SparkFunSuite with
BeforeAndAfter with PrivateM
}
test("MetricsSystem with default config") {
- val metricsSystem = MetricsSystem.createMetricsSystem("default", conf,
securityMgr)
+ val metricsSystem =
+ MetricsSystem.createMetricsSystem(MetricsSystemInstances.TEST, conf,
securityMgr)
Review comment:
Yes it is on purpose. This test wants to use the "default" name to show the
config it used.
I was trying to add a `MetricsSystemInstances.DEFAULT` for this single test
case, but find it hard to understand in instances list. I think it may be
acceptable to name it `MetricsSystemInstances.TEST`, just like the test next to
it. In fact they have the same config. After all, the test logic differences,
not names, are most important.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
