cloud-fan commented on a change in pull request #23883: [SPARK-26982][SQL]
Enhance describe framework to describe the output of a query.
URL: https://github.com/apache/spark/pull/23883#discussion_r260711129
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
##########
@@ -241,14 +241,17 @@ class SparkSqlParserSuite extends AnalysisTest {
test("SPARK-17328 Fix NPE with EXPLAIN DESCRIBE TABLE") {
assertEqual("describe table t",
- DescribeTableCommand(
- TableIdentifier("t"), Map.empty, isExtended = false))
+ DescribeQueryCommand(UnresolvedRelation(TableIdentifier("t", None))))
assertEqual("describe table extended t",
- DescribeTableCommand(
- TableIdentifier("t"), Map.empty, isExtended = true))
+ DescribeTableCommand(TableIdentifier("t"), Map.empty, isExtended = true))
assertEqual("describe table formatted t",
Review comment:
shall we test `describe t` as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
