srowen commented on a change in pull request #23869: [SPARK-26967][CORE] Put
MetricsSystem instance names together for clearer management
URL: https://github.com/apache/spark/pull/23869#discussion_r260790527
##########
File path:
core/src/test/scala/org/apache/spark/metrics/MetricsSystemSuite.scala
##########
@@ -40,7 +40,8 @@ class MetricsSystemSuite extends SparkFunSuite with
BeforeAndAfter with PrivateM
}
test("MetricsSystem with default config") {
- val metricsSystem = MetricsSystem.createMetricsSystem("default", conf,
securityMgr)
+ val metricsSystem =
+ MetricsSystem.createMetricsSystem(MetricsSystemInstances.TEST, conf,
securityMgr)
Review comment:
It looks like they test something different though. "default" has no config,
but "test" has some config defined in `test_metrics_system.properties`. They
assert the difference.
I don't think we need to define a constant for "default". In fact, we
probably don't need a constant for "test"; that can be local to the test class
here. It's not something any other code would reference and not a 'real'
metrics system.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
