HyukjinKwon commented on a change in pull request #23900: [SPARK-23836][PYTHON] 
Add support for StructType return in Scalar Pandas UDF
URL: https://github.com/apache/spark/pull/23900#discussion_r260874304
 
 

 ##########
 File path: python/pyspark/worker.py
 ##########
 @@ -254,7 +254,12 @@ def read_udfs(pickleSer, infile, eval_type):
         timezone = runner_conf.get("spark.sql.session.timeZone", None)
         safecheck = 
runner_conf.get("spark.sql.execution.pandas.arrowSafeTypeConversion",
                                     "false").lower() == 'true'
-        ser = ArrowStreamPandasSerializer(timezone, safecheck)
+        # NOTE: this is duplicated from wrap_grouped_map_pandas_udf
+        assign_cols_by_name = runner_conf.get(
 
 Review comment:
   @BryanCutler, BTW, would you be willing to work on removing 
`spark.sql.legacy.execution.pandas.groupedMap.assignColumnsByName` in Spark 
3.0? I think this makes the codes complicated.
   
   Also, would you mind working on upgrading minimum Arrow to 0.12.0 as well, 
as we discussed? (Probably it better be asked to dev mailing list first to be 
100% sure).
   
   If you're currently busy, I will take one or both.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to