vanzin commented on a change in pull request #23546: [SPARK-23153][K8s] Support
client dependencies with a Hadoop Compatible File System
URL: https://github.com/apache/spark/pull/23546#discussion_r260913388
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -330,6 +347,7 @@ private[spark] class SparkSubmit extends Logging {
}
}
+ // Fill in all spark properties of SparkConf
Review comment:
I'd just move this initialization to the top of the function, then code can
be consistent in always using `sparkConf`.
And yes, this code is very confusing and probably does a lot of redundant
things. Which I why I asked you to start with the plugin idea in the other PR,
in the hopes that we can clean this up little by little.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
