mccheah commented on a change in pull request #23915: SPARK-24252: Add v2
catalog plugin system.
URL: https://github.com/apache/spark/pull/23915#discussion_r261030599
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
##########
@@ -620,6 +622,12 @@ class SparkSession private(
*/
@transient lazy val catalog: Catalog = new CatalogImpl(self)
+ @transient private lazy val catalogs = new mutable.HashMap[String,
CatalogPlugin]()
Review comment:
Should there be some best-effort lifecycle for stopping or closing these
catalog plugins? I'm wondering for example if we want to close connections to
databases when the Spark Session shuts down. Maybe add a `stop()` API and
calling it from `SparkSession#stop`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
