viirya commented on a change in pull request #23916:
[SPARK-22000][SQL][FOLLOWUP] Add comment and simple cleanup to
DeserializerBuildHelper
URL: https://github.com/apache/spark/pull/23916#discussion_r261048845
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##########
@@ -322,13 +322,12 @@ object ScalaReflection extends ScalaReflection {
val newTypePath = (s"""- field (class: "$clsName", """ +
s"""name: "$fieldName")""") +: walkedTypePath
- // For tuples, we based grab the inner fields by ordinal instead of
name.
deserializerForWithNullSafety(
path,
- dataType,
nullable = nullable,
newTypePath,
(expr, typePath) => {
+ // For tuples, we based grab the inner fields by ordinal instead
of name.
Review comment:
This location should be more proper for this comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
