dilipbiswal commented on a change in pull request #23897:
[SPARK-26215][SQL][FOLLOW-UP][MINOR] Fix the warning from ANTR4
URL: https://github.com/apache/spark/pull/23897#discussion_r261081585
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -78,11 +78,11 @@ singleTableSchema
statement
: query
#statementDefault
| USE db=identifier #use
- | CREATE DATABASE (IF NOT EXISTS)? identifier
+ | CREATE database (IF NOT EXISTS)? identifier
Review comment:
@beliefer I think database in lower case indicates a parser rule and
different from database in upper case which is a lexer rule. We already have a
precedence in our grammar file for "identifier". IMHO keeping it as database
reads better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
