Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2872#discussion_r21873430
--- Diff: ec2/spark_ec2.py ---
@@ -341,11 +355,11 @@ def launch_cluster(conn, opts, cluster_name):
if opts.ami is None:
opts.ami = get_spark_ami(opts)
- additional_groups = []
+ additional_group_ids = []
if opts.additional_security_group:
- additional_groups = [sg
- for sg in conn.get_all_security_groups()
- if opts.additional_security_group in
(sg.name, sg.id)]
+ additional_group_ids = [sg.id
--- End diff --
If this change from `sg` to `sg.id` is due to
https://github.com/boto/boto/issues/350, can you add a comment referencing that
issue? Something like
```
# we use group ids to work around https://github.com/boto/boto/issues/350
```
would be fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
