viirya commented on a change in pull request #23802: [SPARK-26893][SQL] Allow
partition pruning with subquery filters on file source
URL: https://github.com/apache/spark/pull/23802#discussion_r261247179
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -185,6 +185,10 @@ case class FileSourceScanExec(
ret
}
+ private def partitionOnlyAvailableAtRuntime: Boolean = {
+ partitionFilters.exists(ExecSubqueryExpression.hasSubquery)
+ }
Review comment:
I need to rethink to link the meaning of `partitionOnlyAvailableAtRuntime`
to its implementation and understand its usage below.
I'd prefer to rename this as something like
`hasPartitionsAvailableAtRunTime` and add some comments to explain its usage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
