vanzin commented on a change in pull request #23790: [SPARK-26792][CORE] Apply 
custom log URL to Spark UI
URL: https://github.com/apache/spark/pull/23790#discussion_r261352295
 
 

 ##########
 File path: 
core/src/test/scala/org/apache/spark/scheduler/CoarseGrainedSchedulerBackendSuite.scala
 ##########
 @@ -120,6 +124,63 @@ class CoarseGrainedSchedulerBackendSuite extends 
SparkFunSuite with LocalSparkCo
     }
   }
 
+  // Here we just have test for one happy case instead of all cases: other 
cases are covered in
+  // FsHistoryProviderSuite.
+  test("custom log url for Spark UI is applied") {
+    val customExecutorLogUrl = 
"http://newhost:9999/logs/clusters/{{CLUSTER_ID}}/users/{{USER}}"; +
+      "/containers/{{CONTAINER_ID}}/{{FILE_NAME}}"
+
+    val conf = new SparkConf()
+      .set(CPUS_PER_TASK, 2)
 
 Review comment:
   Unnecessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to