LucaCanali commented on a change in pull request #23838: [SPARK-26928][CORE]
Add driver CPU Time to the metrics system
URL: https://github.com/apache/spark/pull/23838#discussion_r261392070
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -499,6 +499,13 @@ package object config {
.stringConf
.createOptional
+ private[spark] val METRICS_CPU_TIME_DRIVER_ENABLED =
Review comment:
On second thoughts adding a flag/configuratoni parameter is probably not
necessary and can be removed, as the JVMCPU source should be quite safe. We
have been using it for the executor instance for a while. Also the
implementation takes care of various error conditions that can occur for
exmaple with JVMs that don't implement "ProcessCpuTime"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
