HeartSaVioR commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons 
Pool to KafkaDataConsumer
URL: https://github.com/apache/spark/pull/22138#issuecomment-468507058
 
 
   I understand about your request to see some numbers to verify whether it 
doesn't introduce perf. regression (as current code also does caching, so we 
cannot expect "noticeable" perf improvement).
   
   My major concern was request regarding `production`, as I don't see any 
similar request previously. I'll try to construct experiment env. and get 
numbers and get back to you.
   
   Btw, please don't evaluate this patch as "performance improvement", though I 
wouldn't bring "regression". (That's what "kindly ask..." sentence meant)  This 
patch also brings bugfix and improvements other than performance perspective.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to