dongjoon-hyun commented on a change in pull request #23805: [SPARK-26420][k8s]
Generate more unique IDs when creating k8s resource names.
URL: https://github.com/apache/spark/pull/23805#discussion_r261477306
##########
File path:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/DriverServiceFeatureStepSuite.scala
##########
@@ -91,26 +92,37 @@ class DriverServiceFeatureStepSuite extends SparkFunSuite {
assert(additionalProps(DRIVER_BLOCK_MANAGER_PORT.key) ===
DEFAULT_BLOCKMANAGER_PORT.toString)
}
- test("Long prefixes should switch to using a generated name.") {
- val clock = new ManualClock()
- clock.setTime(10000)
+ test("Long prefixes should switch to using a generated unique name.") {
val sparkConf = new SparkConf(false)
.set(KUBERNETES_NAMESPACE, "my-namespace")
- val configurationStep = new DriverServiceFeatureStep(
- KubernetesTestConf.createDriverConf(
- sparkConf = sparkConf,
- resourceNamePrefix = Some(LONG_RESOURCE_NAME_PREFIX),
- labels = DRIVER_LABELS),
- clock)
- val driverService = configurationStep
- .getAdditionalKubernetesResources()
- .head
- .asInstanceOf[Service]
- val expectedServiceName =
s"spark-10000${DriverServiceFeatureStep.DRIVER_SVC_POSTFIX}"
- assert(driverService.getMetadata.getName === expectedServiceName)
- val expectedHostName = s"$expectedServiceName.my-namespace.svc"
- val additionalProps = configurationStep.getAdditionalPodSystemProperties()
- verifySparkConfHostNames(additionalProps, expectedHostName)
+ val kconf = KubernetesTestConf.createDriverConf(
+ sparkConf = sparkConf,
+ resourceNamePrefix = Some(LONG_RESOURCE_NAME_PREFIX),
+ labels = DRIVER_LABELS)
+ val clock = new ManualClock()
+
+ // Ensure that multiple services created at the same time generate unique
names.
+ val services = (1 to 10).map { _ =>
+ val configurationStep = new DriverServiceFeatureStep(kconf, clock =
clock)
+ val serviceName = configurationStep
+ .getAdditionalKubernetesResources()
+ .head
+ .asInstanceOf[Service]
+ .getMetadata
+ .getName
+
+ val hostAddress = configurationStep
+ .getAdditionalPodSystemProperties()(DRIVER_HOST_ADDRESS.key)
+
+ (serviceName -> hostAddress)
+ }.toMap
Review comment:
Nice!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
