maropu commented on issue #23908:  [SPARK-27001][SQL] Refactor "serializerFor" 
method between ScalaReflection and JavaTypeInference
URL: https://github.com/apache/spark/pull/23908#issuecomment-468544069
 
 
   Nice work, @HeartSaVioR! btw, this pr consists of the two parts you 
described in the PR description. If so, how about splitting this into the two 
prs for easy reviews? Refactoring the code for the consistency between 
ScalaReflection and JavaTypeInference, and adding WalkedTypePath then?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to