sujith71955 commented on a change in pull request #23921: SPARK-26560:Repeat
select on HiveUDF fails
URL: https://github.com/apache/spark/pull/23921#discussion_r261521104
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala
##########
@@ -66,51 +66,58 @@ private[sql] class HiveSessionCatalog(
name: String,
clazz: Class[_],
input: Seq[Expression]): Expression = {
-
- Try(super.makeFunctionExpression(name, clazz, input)).getOrElse {
- var udfExpr: Option[Expression] = None
- try {
- // When we instantiate hive UDF wrapper class, we may throw exception
if the input
- // expressions don't satisfy the hive UDF, such as type mismatch,
input number
- // mismatch, etc. Here we catch the exception and throw
AnalysisException instead.
- if (classOf[UDF].isAssignableFrom(clazz)) {
- udfExpr = Some(HiveSimpleUDF(name, new
HiveFunctionWrapper(clazz.getName), input))
- udfExpr.get.dataType // Force it to check input data types.
- } else if (classOf[GenericUDF].isAssignableFrom(clazz)) {
- udfExpr = Some(HiveGenericUDF(name, new
HiveFunctionWrapper(clazz.getName), input))
- udfExpr.get.dataType // Force it to check input data types.
- } else if
(classOf[AbstractGenericUDAFResolver].isAssignableFrom(clazz)) {
- udfExpr = Some(HiveUDAFFunction(name, new
HiveFunctionWrapper(clazz.getName), input))
- udfExpr.get.dataType // Force it to check input data types.
- } else if (classOf[UDAF].isAssignableFrom(clazz)) {
- udfExpr = Some(HiveUDAFFunction(
- name,
- new HiveFunctionWrapper(clazz.getName),
- input,
- isUDAFBridgeRequired = true))
- udfExpr.get.dataType // Force it to check input data types.
- } else if (classOf[GenericUDTF].isAssignableFrom(clazz)) {
- udfExpr = Some(HiveGenericUDTF(name, new
HiveFunctionWrapper(clazz.getName), input))
- udfExpr.get.asInstanceOf[HiveGenericUDTF].elementSchema // Force it
to check data types.
+ val originalClassLoader = Thread.currentThread().getContextClassLoader()
+ Thread.currentThread().setContextClassLoader(clazz.getClassLoader)
+ try {
+ Try(super.makeFunctionExpression(name, clazz, input)).getOrElse {
+ var udfExpr: Option[Expression] = None
+ try {
+ // When we instantiate hive UDF wrapper class, we may throw
exception if the input
+ // expressions don't satisfy the hive UDF, such as type mismatch,
input number
+ // mismatch, etc. Here we catch the exception and throw
AnalysisException instead.
+ if (classOf[UDF].isAssignableFrom(clazz)) {
+ udfExpr = Some(HiveSimpleUDF(name, new
HiveFunctionWrapper(clazz.getName), input))
+ udfExpr.get.dataType // Force it to check input data types.
+ } else if (classOf[GenericUDF].isAssignableFrom(clazz)) {
+ udfExpr = Some(HiveGenericUDF(name, new
HiveFunctionWrapper(clazz.getName), input))
+ udfExpr.get.dataType // Force it to check input data types.
+ } else if
(classOf[AbstractGenericUDAFResolver].isAssignableFrom(clazz)) {
+ udfExpr = Some(HiveUDAFFunction(name, new
HiveFunctionWrapper(clazz.getName), input))
+ udfExpr.get.dataType // Force it to check input data types.
+ } else if (classOf[UDAF].isAssignableFrom(clazz)) {
+ udfExpr = Some(HiveUDAFFunction(
+ name,
+ new HiveFunctionWrapper(clazz.getName),
+ input,
+ isUDAFBridgeRequired = true))
+ udfExpr.get.dataType // Force it to check input data types.
+ } else if (classOf[GenericUDTF].isAssignableFrom(clazz)) {
+ udfExpr = Some(HiveGenericUDTF(name, new
HiveFunctionWrapper(clazz.getName), input))
+ udfExpr.get.asInstanceOf[HiveGenericUDTF].elementSchema // Force
it to check data types.
+ }
+ } catch {
+ case NonFatal(e) =>
+ val noHandlerMsg = s"No handler for UDF/UDAF/UDTF
'${clazz.getCanonicalName}': $e"
+ val errorMsg =
+ if (classOf[GenericUDTF].isAssignableFrom(clazz)) {
+ s"$noHandlerMsg\nPlease make sure your function overrides " +
+ "`public StructObjectInspector initialize(ObjectInspector[]
args)`."
+ } else {
+ noHandlerMsg
+ }
+ val analysisException = new AnalysisException(errorMsg)
+ analysisException.setStackTrace(e.getStackTrace)
+ throw analysisException
+ }
+ udfExpr.getOrElse {
+ throw new AnalysisException(s"No handler for UDF/UDAF/UDTF
'${clazz.getCanonicalName}'")
}
- } catch {
- case NonFatal(e) =>
- val noHandlerMsg = s"No handler for UDF/UDAF/UDTF
'${clazz.getCanonicalName}': $e"
- val errorMsg =
- if (classOf[GenericUDTF].isAssignableFrom(clazz)) {
- s"$noHandlerMsg\nPlease make sure your function overrides " +
- "`public StructObjectInspector initialize(ObjectInspector[]
args)`."
- } else {
- noHandlerMsg
- }
- val analysisException = new AnalysisException(errorMsg)
- analysisException.setStackTrace(e.getStackTrace)
- throw analysisException
- }
- udfExpr.getOrElse {
- throw new AnalysisException(s"No handler for UDF/UDAF/UDTF
'${clazz.getCanonicalName}'")
}
}
+ finally
+ {
Review comment:
pull up the flower bracket inline with finally
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
