vanzin commented on a change in pull request #23931: [SPARK-26048][build] Enable flume profile when creating 2.x releases. URL: https://github.com/apache/spark/pull/23931#discussion_r261733892
########## File path: dev/create-release/release-build.sh ########## @@ -116,14 +116,17 @@ SCALA_2_11_PROFILES= if [[ $SPARK_VERSION > "2.3" ]]; then BASE_PROFILES="$BASE_PROFILES -Pkubernetes" if [[ $SPARK_VERSION < "3.0." ]]; then - SCALA_2_11_PROFILES="-Pkafka-0-8" + SCALA_2_11_PROFILES="-Pkafka-0-8 -Pflume" fi Review comment: In the past I've avoided using the release scripts from the branches for a bunch of reasons. But mainly: - if you find a problem with the release script in the middle of building an RC, it's awkward to change the script in the branch without creating a new RC. - as master moves forward, it becomes tricky to backport fixes from the master scripts to other branches So I've always used the release scripts from master, and I think it's much simpler for everybody if they also do that. (Note that even though the 2.4 script has the flume profile enabled, 2.4.0 was shipped without a flume artifact published to maven.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
