cloud-fan commented on a change in pull request #23871:
[SPARK-23433][SPARK-25250] [CORE] Later created TaskSet should learn about the
finished partitions
URL: https://github.com/apache/spark/pull/23871#discussion_r261811654
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
##########
@@ -202,8 +205,11 @@ private[spark] class TaskSchedulerImpl(
val tasks = taskSet.tasks
logInfo("Adding task set " + taskSet.id + " with " + tasks.length + "
tasks")
this.synchronized {
- val manager = createTaskSetManager(taskSet, maxTaskFailures)
val stage = taskSet.stageId
+ // only create a BitSet once for a certain stage since we only remove
+ // that stage when an active TaskSetManager succeed.
+ stageIdToFinishedPartitions.getOrElseUpdate(stage, new BitSet)
Review comment:
nit: can we move it to `createTaskSetManager`, and keep `submitTasks`
untouched?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
