srowen commented on a change in pull request #23934: [MINOR][DOC] Updated 
PySpark Binarizer docstring to match Scala's.
URL: https://github.com/apache/spark/pull/23934#discussion_r261873912
 
 

 ##########
 File path: python/pyspark/ml/feature.py
 ##########
 @@ -86,7 +86,9 @@ class Binarizer(JavaTransformer, HasInputCol, HasOutputCol, 
JavaMLReadable, Java
     """
 
     threshold = Param(Params._dummy(), "threshold",
-                      "threshold in binary classification prediction, in range 
[0, 1]",
+                      "Param for threshold used to binarize continuous 
features.
+The features greater than the threshold will be binarized to 1.0. 
 
 Review comment:
   I think this might not pass the style check either (`./dev/lint-python` will 
check it locally BTW). This also puts some whitespace in the string I think. 
Try this:
   
   ```
   threshold = Param(Params._dummy(), "threshold",
                                    "Param for ... " + 
                                    "The features greater ...",
                                    ...)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to