cloud-fan commented on a change in pull request #23750: [SPARK-19712][SQL] Pushing Left Semi and Left Anti joins through Project, Aggregate, Window, Union etc. URL: https://github.com/apache/spark/pull/23750#discussion_r261911542
########## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/LeftSemiAntiJoinPushDownSuite.scala ########## @@ -0,0 +1,299 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.optimizer + +import org.apache.spark.sql.catalyst.analysis.EliminateSubqueryAliases +import org.apache.spark.sql.catalyst.dsl.expressions._ +import org.apache.spark.sql.catalyst.dsl.plans._ +import org.apache.spark.sql.catalyst.expressions._ +import org.apache.spark.sql.catalyst.plans._ +import org.apache.spark.sql.catalyst.plans.logical._ +import org.apache.spark.sql.catalyst.rules._ +import org.apache.spark.sql.types.IntegerType +import org.apache.spark.unsafe.types.CalendarInterval + +class LeftSemiPushdownSuite extends PlanTest { + + object Optimize extends RuleExecutor[LogicalPlan] { + val batches = + Batch("Subqueries", Once, + EliminateSubqueryAliases) :: + Batch("Filter Pushdown", FixedPoint(10), + CombineFilters, + PushDownPredicate, + PushDownLeftSemiAntiJoin, + BooleanSimplification, + CollapseProject) :: Nil + } + + val testRelation = LocalRelation('a.int, 'b.int, 'c.int) + + val testRelation1 = LocalRelation('d.int) + + test("Project: LeftSemiAnti join pushdown") { + val originalQuery = testRelation + .select(star()) + .join(testRelation1, joinType = LeftSemi, condition = Some('b === 'd)) + + val optimized = Optimize.execute(originalQuery.analyze) + val correctAnswer = testRelation + .join(testRelation1, joinType = LeftSemi, condition = Some('b === 'd)) + .select('a, 'b, 'c) + .analyze + comparePlans(optimized, correctAnswer) + } + + test("Project: LeftSemiAnti join no pushdown because of non-deterministic proj exprs") { + val originalQuery = testRelation + .select(Rand('a), 'b, 'c) + .join(testRelation1, joinType = LeftSemi, condition = Some('b === 'd)) + + val optimized = Optimize.execute(originalQuery.analyze) + val correctAnswer = testRelation + .select(Rand('a), 'b, 'c) + .join(testRelation1, joinType = LeftSemi, condition = Some('b === 'd)) + .analyze + + comparePlans(optimized, correctAnswer) + } + + test("Project: LeftSemiAnti join non correlated scalar subq") { + val subq = ScalarSubquery(testRelation.groupBy('b)(sum('c).as("sum")).analyze) + val originalQuery = testRelation + .select(subq.as("sum")) + .join(testRelation1, joinType = LeftSemi, condition = Some('sum === 'd)) + + val optimized = Optimize.execute(originalQuery.analyze) + val correctAnswer = testRelation + .join(testRelation1, joinType = LeftSemi, condition = Some(subq === 'd)) + .select(subq.as("sum")) + .analyze + + comparePlans(optimized, correctAnswer) + } + + test("Project: LeftSemiAnti join no pushdown - correlated scalar subq in projection list") { + val testRelation2 = LocalRelation('e.int, 'f.int) + val subqPlan = testRelation2.groupBy('e)(sum('f).as("sum")).where('e === 'a) + val subqExpr = ScalarSubquery(subqPlan) + val originalQuery = testRelation + .select(subqExpr.as("sum")) + .join(testRelation1, joinType = LeftSemi, condition = Some('sum === 'd)) + + val optimized = Optimize.execute(originalQuery.analyze) + val correctAnswer = testRelation Review comment: ditto, `val correctAnswer = originalQuery.analyzed` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
