gaborgsomogyi commented on a change in pull request #23797:
[SPARK-26856][PYSPARK] Python support for from_avro and to_avro APIs
URL: https://github.com/apache/spark/pull/23797#discussion_r262037336
##########
File path: dev/sparktestsupport/modules.py
##########
@@ -178,6 +178,10 @@ def __hash__(self):
],
sbt_test_goals=[
"avro/test",
+ ],
+ python_test_goals=[
+ # doctests
+ "pyspark.sql.avro.functions"
Review comment:
@HyukjinKwon
> I think this isn't detected properly when there are only Avro related
changes.
I've double checked the avro change only detection with the following:
```
determine_modules_for_files(["external/avro/foo"])
['avro']
```
and seems like it's working. Have you tested it differently?
> Also, I think we should somehow put this into `pyspark-sql` module.
You mean here adding the doc test into `pyspark-sql`s `python_test_goals`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
