liupc commented on issue #23842: [SPARK-26927]Fix race condition may cause 
dynamic allocation not working
URL: https://github.com/apache/spark/pull/23842#issuecomment-469239271
 
 
   > But it may be still possible that removedExecutorIds to be full due to 
plenty of TaskStartEvents blocked for a long long time theoretically. If it 
really happens, I'd choose to fail the entire ExecutorAllocationManager 
immediately
   
   @Ngone51 Good idea, but I think we can just drop these events and print some 
logging if the `removedExecutorIds` to be full due to plenty of TaskStartEvents 
blocked for a long long time, because it's even worse by failing the 
application. 
   Actually, The events may be dropped in the `executorManagement` queue, and 
cause some unexpected behavior,  and we now let it go and print some warning 
logs. I think we can do the similar   ops for this case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to