gaborgsomogyi commented on a change in pull request #23956: [SPARK-27042][SS]
Close cached Kafka consumer in case of task retry
URL: https://github.com/apache/spark/pull/23956#discussion_r262056137
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaProducer.scala
##########
@@ -79,6 +79,10 @@ private[kafka010] object CachedKafkaProducer extends
Logging {
* one instance per specified kafkaParams.
*/
private[kafka010] def getOrCreate(kafkaParams: ju.Map[String, Object]):
Producer = {
+ if (TaskContext.get != null && TaskContext.get.attemptNumber >= 1) {
+ logDebug(s"Reattempt detected, invalidating cached producer for params
$kafkaParams")
+ close(kafkaParams)
Review comment:
Since any part of the code can throw exception which may or may not caught I
thought this is the most safe solution. The other consideration was that the
consumer part works similar way without problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
