dongjoon-hyun commented on a change in pull request #23955: [SPARK-27043][SQL]
Nested schema pruning benchmark for ORC
URL: https://github.com/apache/spark/pull/23955#discussion_r262124220
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/NestedSchemaPruningBenchmark.scala
##########
@@ -151,7 +144,7 @@ object NestedSchemaPruningBenchmark extends
SqlBasedBenchmark {
override def runBenchmarkSuite(mainArgs: Array[String]): Unit = {
runBenchmark(s"Nested Schema Pruning Benchmark") {
Review comment:
Shall we parameterize this `s"Nested Schema Pruning Benchmark"` like
`dataSourceName`? Currently, the content of all result files look identical
(except the file name).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
