srowen commented on a change in pull request #23946: [SPARK-26860][PySpark] Fix
for RangeBetween docs appear to be wrong
URL: https://github.com/apache/spark/pull/23946#discussion_r262129626
##########
File path: R/pkg/R/WindowSpec.R
##########
@@ -127,6 +127,19 @@ setMethod("orderBy",
#' "0" means "current row", while "-1" means the row before the current row,
and "5" means the
#' fifth row after the current row.
#'
+#' We recommend users use \code{Window.unboundedPreceding},
\code{Window.unboundedFollowing},
+#' and \code{Window.currentRow} to specify special boundary values, rather
than using long values
+#' directly.
+#'
+#' A range-based boundary is based on the actual value of the ORDER BY
+#' expression(s). An offset is used to alter the value of the ORDER BY
expression, for
Review comment:
I'm having trouble with this text -- not sure it 'alters' the values of an
expression? ", for" should begin a new sentence. "order by" isn't capitalized
consistently. Is this taken from a Scala example?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
