arunmahadevan commented on a change in pull request #23912: [SPARK-21029][SS]
StreamingQuery should be stopped when the SparkSession is stopped
URL: https://github.com/apache/spark/pull/23912#discussion_r262160783
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
##########
@@ -742,6 +749,22 @@ class SparkSession private(
DataType.fromJson(dataTypeString)
}
+ /**
+ * Stops all active streaming queries
+ */
+ private def stopStreamingQueries(): Unit = {
+ if (!sparkContext.isStopped) {
+ streams.active.foreach { query =>
Review comment:
Yes its possible. Theres a
[check](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala#L142)
that ensures the query execution thread is still alive before stopping it.
Also this is best effort attempt to stop the running queries and if the stop
fails, we log and continue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
