vanzin commented on a change in pull request #23930: [SPARK-27021][CORE]
Cleanup of Netty event loop group for shuffle chunk fetch requests
URL: https://github.com/apache/spark/pull/23930#discussion_r262171302
##########
File path:
common/network-shuffle/src/test/java/org/apache/spark/network/sasl/SaslIntegrationSuite.java
##########
@@ -223,41 +222,33 @@ public void onBlockFetchFailure(String blockId,
Throwable t) {
StreamHandle stream = (StreamHandle)
BlockTransferMessage.Decoder.fromByteBuffer(response);
long streamId = stream.streamId;
+ try (
Review comment:
Indentation here is funny. For these long tries I generally use:
```
try (
Foo f1 = ...;
Foo f2 = ...;
) {
// code here
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
