squito commented on a change in pull request #23393: [SPARK-26288][CORE]add
initRegisteredExecutorsDB
URL: https://github.com/apache/spark/pull/23393#discussion_r262250140
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java
##########
@@ -66,6 +66,11 @@ public ExternalShuffleBlockHandler(TransportConf conf, File
registeredExecutorFi
new ExternalShuffleBlockResolver(conf, registeredExecutorFile));
}
+ /** ForTesting */
Review comment:
can you use the same style for labelling the "for testing" methods as
already in these files? I think for all of these java files its
`@VisibleForTestin`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
