shahidki31 commented on a change in pull request #23939: [SPARK-27019]
[webUI]onJobStart happens after onExecutionEnd shouldn't overwrite kvstore
URL: https://github.com/apache/spark/pull/23939#discussion_r262378165
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala
##########
@@ -276,15 +304,20 @@ class SQLAppStatusListener(
update(exec)
// Remove stale LiveStageMetrics objects for stages that are not active
anymore.
- val activeStages = liveExecutions.values().asScala.flatMap { other =>
- if (other != exec) other.stages else Nil
- }.toSet
- stageMetrics.keySet().asScala
- .filter(!activeStages.contains(_))
- .foreach(stageMetrics.remove)
+ removeStaleMetricsData(exec)
}
}
+ private def removeStaleMetricsData(exec: LiveExecutionData): Unit = {
+ // Remove stale LiveStageMetrics objects for stages that are not active
anymore.
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
